[U-Boot-Users] New! Improved! [PATCHES] For The 8540ADS/8560ADS

Wolfgang Denk wd at denx.de
Sat Jul 10 01:25:56 CEST 2004

In message <1087513856.15094.12.camel at blarg.somerset.sps.mot.com> you wrote:
> The enclosed patch, MPC85XXADS-20040617-diffs.tgz, should clean up
> the remaining issues from my previous patches for the 8540ADS and
> 8560ADS boards.  These patches are relative to the top of CVS
> on 15-June-2004.
> It should address some of your concerns as well.  Please let me
> know if you need any other fixes.

Please stick to the Coding Style:

Don't add trailing white space!
Use TAB for indentation, not spaces.
Indentation is always 8 columns (a TAB).

I reject the following parts:


        Don't create redundand code. No need to introduce a new macro
        DEB() if there is already debug() which does the  same,  just

        If there were any other changes to this file  than  this  and
        bogus reformatting they are lost.

And... please: don't create a tarball for just a single file.  Simply
gzipping it is not more work for you and less work for me.

All the rest: added & checked in.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Time is a drug. Too much of it kills you.
                                      - Terry Pratchett, _Small Gods_

More information about the U-Boot mailing list