[U-Boot-Users] Patches [Part 2/2] for the MPC8540ADS and MPC8560ADS boards

[Jon Loeliger]

On Tue, 2004-06-08 at 19:51, Wolfgang Denk wrote:
> Jon,
> 
> in message <1084311864.30409.103.camel at gleep.sps.mot.com> you wrote:
> > 
> > Here are some patches for the MPC 8540/8560 ADS boards.
> > The patches are in two .tgz files, part 1 and part 2.
> > This is part 2.
> 
> This is not a patch, this is just CRAP.
> 
> Why are you messing around with files which have nothing to do with this?

Good question.  I had no intention of doing so.

> Why are you make garbage out of  files  like  drivers/sl811_usb.c  or
> fs/jffs2/jffs2_1pass.c or include/configs/PM520.h ???

This is a good catch.  You are correct in stopping this patch.
I will clean this up.  My guess is that I had an incorrect basis
for my patch creation in our tree.  My apologies.

> Who gives you the right to place a "Copyright 2004 Freescale
> Semiconductor" on files like "include/asm-ppc/mmu.h",
> "include/asm-ppc/processor.h" and so on???
> 
> Why do you mess with white space in include/configs/MPC8540ADS.h,
> include/configs/MPC8560ADS.h, include/pci_ids.h, MAKEALL, Makefile
> etc.?

Wolfgang, there is a larger effort at work here.  In particular,
this is an effort to make these two files as similar as possible
in order to refactor their common code out into a better
abstraction for multiple families of processors, CPUs, cores
and boards.

> 
> Partially applied, until I gave up.
> 
> Please clean up this mess yourself.

I'll look into it.

> 
> Feel free to resubmit the missing parts. But please make sure to be a
> bit more careful next time.

Will do.

jdl