[U-Boot-Users] [PATCH 2/2] LPD7A40x flash cleanup

Wolfgang Denk wd at denx.de
Thu Jun 10 23:46:17 CEST 2004


In message <200406101318.31803.pruhland at microwavedata.com> you wrote:
> 
> This patch cleans up some debug code leftover in lpd7a40x board support.

Where is the CHANGELOG entry?


> -		reset_timer();
> +		reset_timer_masked();

That was really a "debug code leftover" ????

> -			tstart = get_timer(0);
>  			do {
> -				ulong now;
>  				/* check timeout */
> -				//if (get_timer_masked () > CFG_FLASH_ERASE_TOUT) {
> -				if ((now = get_timer(tstart)) > CFG_FLASH_ERASE_TOUT) {
> -					printf("tstart = 0x%08lx, now = 0x%08lx\n", tstart, now);
> +				if (get_timer_masked () > CFG_FLASH_ERASE_TOUT) {
>  					*addr = CMD_STATUS_RESET;
>  					result = BIT_TIMEOUT;
>  					break;

Are you sure your patch description is correct?

Rejected. Please provide a description that matches what you are doing.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Every living thing wants to survive.
	-- Spock, "The Ultimate Computer", stardate 4731.3




More information about the U-Boot mailing list