[U-Boot-Users] [Patch] flashh

[Wolfgang Denk]

Dear Robert,

in message <20040513144720.GS27774 at pengutronix.de> you wrote:
> 
> * Patch by Kai-Uwe Bloem, Robert Schwebel, 13 May 2004:
>   Add support for Intel K3 strata flashs.       

Parts of this patch have been obsolteted by recent  additions,  other
parts are IMHO wrong:

> --- u-boot-ptx-test/include/flash.h~flashh	2004-02-10 12:44:30.000000000 +0100
> +++ u-boot-ptx-test/include/flash.h	2004-02-10 13:03:21.000000000 +0100
> @@ -231,6 +231,9 @@
>  #define INTEL_ID_28F160S3   0x00D000D0	/*  16M = 512K x  32 (64kB x 32)	*/
>  #define INTEL_ID_28F320S3   0x00D400D4	/*  32M = 512K x  64 (64kB x 64)	*/
>  
> +#define INTEL_ID_28F128K3   0x88028802	/* 128M = 128K x 128			*/
> +#define INTEL_ID_28F256K3   0x88038803	/* 256M = 128K x 256			*/
> +

Already included now.

>  /* Note that the Sharp 28F016SC is compatible with the Intel E28F016SC */
>  #define SHARP_ID_28F016SCL  0xAAAAAAAA	/* LH28F016SCT-L95 2Mx8, 32 64k blocks	*/
>  #define SHARP_ID_28F016SCZ  0xA0A0A0A0	/* LH28F016SCT-Z4  2Mx8, 32 64k blocks	*/
> @@ -340,6 +343,9 @@
>  #define FLASH_AMDL163T	0x00B2		/* AMD AM29DL163T (2M x 16 )			*/
>  #define FLASH_AMDL163B	0x00B3
>  
> +#define FLASH_28F128K3  0x00A7		/* Intel 28F128K3  ( 128M = 8M x 16 )   */

This is IMHO wrong. The comment a few lines above reads:

	Be careful when adding new type! Odd numbers are "bottom boot sector" types!

I don't think this is a bottom boot sector type.

> +#define FLASH_28F256K3  0x00A8		/* Intel 28F256K3  ( 256M = 16M x 16 )  */
> +

Already included now.

Please fix and resubmit if needed.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
I distrust all systematisers, and avoid them. The will  to  a  system
shows a lack of honesty.
- Friedrich Wilhelm Nietzsche _Götzen-Dämmerung [The Twilight of  the
Idols]_ ``Maxims and Missiles'' no. 26