[U-Boot-Users] [PATCH] Generic Support for Motorola i.MX architecture

[Wolfgang Denk]

In message <20040627192709.GK21651 at pengutronix.de> you wrote:
> 
> Sidenote: it is difficult to audit this patch for trailing whitespace as
> the patch context contains that much of it that you don't see the needle
> in the haystack =8-)

No, this is actually trivial. Use the toolbox:

	bash$ egrep '^\+.*[^I ]$' u-boot-imx1.diff  | wc -l
	     21

There are 21 cases where you insert trailing whitespace.

There are 39 cases where you use space instead of TAB for indentation.

There are 9 cases where you use C++ comments in non-C++ files.

There are 5 cases where you use DOS '\r\n' line feeds

There is one case where you add more than 2 empty lines to a source file

There are 4 cases where you add trailing empty lines to source files

Please cleanup and resubmit.

> * Patch by Sascha Hauer, 27 Jun 2004:
>   Split mx1ads stuff into generic imx and platform parts
>   Add support for Synertronixx scb9328, Viasys FlowScreen 2

It seems the patch does more than just this. For example, I see  that
it modifies the code for interrupt handling for all ARM9 systems?

Please make sure the description is complete.

> Wolfgang, do you prefer the code being split into separate pieces for
> the single tasks?

If the patch is clean this is not necessary.



Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Microsoft Compatibility:
     your old Windows 3.11 application crash exactly as the new ones.