[U-Boot-Users] Patch: ARM Integrator AP, CP and Versatile PB926EJ-S

[Phillippe Robin]

Wolfgang,

Thanks for taking this in. 

You are right about the #ifdef OMAP, but this is not needed anymore in
the version of the file which is in cvs.

Change in the line handling code in lib_arm/armlinux.c:
setup_commandline_tag(). This to cover cases where commandline is a NULL
pointer (which may be the case if it has not been set in the
environment). In this case we can still boot a Linux kernel which has a
hardcoded commandline.

I looked in files for other architectures but they do already check
this. It is in the attached patch.

Kind regards,
Philippe


> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de] 
> Sent: 14 March 2004 15:06
> To: Philippe Robin
> Cc: u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] Patch: ARM Integrator AP, CP and 
> Versatile PB926EJ-S 
> 
> In message 
> <4.2.0.58.20040309122054.01d991a8 at cam-pop.cambridge.arm.com> 
> you wrote:
> >
> > Please find attached a patch against u-boot-1.0.0 to support the 
> > following development boards: ARM Integrator AP, ARM 
> Integrator CP and 
> > Versatile PB926EJ-S. Documentation on these platforms can 
> be found on 
> > http://www.arm.com/products/DevTools/Hardware_Platforms.html.
> 
> I tried to apply your patch, but did so  only  partially.  
> There  are some  conflicts  against  the  current  version of 
> the code, and some modifications don't make sense to me.
> 
> For example, in cpu/arm926ejs/start.S  you  make  code  
> dependent  on "#ifdef OMAP" - should this not be "CONFIG_OMAP"?
> 
> I omitted these parts of your patch. Please check against top 
> of tree in CVS and resubmit any missing stuff.
> 
> 
> I also omitted your modification command of the line handling 
> code in lib_arm/armlinux.c; please explain what you're trying 
> to  fix  there, and  why.  If this is required, then please 
> resubmit, but include the other architectures as well.
> 
> 
> Finally, please aslo submit patches for the required entries  
> to  the MAINTAINERS and CREDITS files.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
> Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: 
> wd at denx.de Pain is a thing of the mind.  The mind can be controlled.
> 	-- Spock, "Operation -- Annihilate!" stardate 3287.2
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-u-boot.arm2
Type: application/octet-stream
Size: 1308 bytes
Desc: patch-u-boot.arm2
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040316/efb75d85/attachment.obj