[U-Boot-Users] [PATCH] lan91c96 driver MAC address detection

[Wolfgang Denk]

In message <409766D3.2030409 at mpc-data.co.uk> you wrote:
> 
> > I have a minor suggestion though. Can we squelch
> > the warning for the "setenv ethaddr" case? Like so:
> Sure, I have no preference either way. I think I originally put in the 
> warning as I have the impression that Wolfgang's preference is to
> have the user use the environment to set the MAC address rather than
> have it detected. 

The rules are simple and documented:

o If the SROM has a valid MAC address, and there is no address in the
  environment, the SROM's address is used.

o If there is no valid address in the SROM, and a definition in the
  environment exists, then the value from the environment variable is
  used.

o If both the SROM and the environment contain a MAC address, and
  both addresses are the same, this MAC address is used.

o If both the SROM and the environment contain a MAC address, and the
  addresses differ, the value from the environment is used and a
  warning is printed.

o If neither SROM nor the environment contain a MAC address, an error
  is raised.


> Of course the easiest way to suppress the message is to do a 'bootp' 
> to read teh detected address, and then 'saveenv' to set it permenently.

You cannot use BOOTP (nor ony  other  network  related  protocol)  to
detect a MAC address!!!


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
It is easier to write an incorrect program than understand a  correct
one.