[U-Boot-Users] [Patch] cmdbootz

[Wolfgang Denk]

In message <20040513143623.GO27774 at pengutronix.de> you wrote:
> 
> * Patch by Holger Schurig, Robert Schwebel, 13 May 2004:
>   Add a 'bootz' command to boot normal Linux zImages in
>   case you don't need the features of U-Boot's uImage. 

I reject this patch.

The newly added code is not added to any Makefile, so it does not get
compiled at all.

If you add it, you will see that it is highly unportable; for  example
on a PowerPC system you get:

	cmd_bootz.c:29:17: tag.h: No such file or directory

Most  of  the  code  seems  to  be  for  ARM  only  (functions   like
setup_*_tag() don't exist for PowerPC or MIPS or ...).

Please make this code usable for  other  architectures  as  well  and
resubmit.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
In accord with UNIX philosophy, Perl gives you enough  rope  to  hang
yourself.              - L. Wall & R. L. Schwartz, _Programming Perl_