[U-Boot-Users] [PATCH] !CFG_MEMTEST_SCRATCH - do not dereference NULL

[VanBaren, Gerald (AGRE)]

> -----Original Message-----
> From: Anders Larsen [mailto:alarsen at rea.de]
> Sent: Monday, November 29, 2004 9:33 AM
> To: Ladislav Michl
> Cc: u-boot-users at lists.sourceforge.net; VanBaren, Gerald (AGRE)
> Subject: Re: [U-Boot-Users] [PATCH] !CFG_MEMTEST_SCRATCH - do
> not dereference NULL
>
> "VanBaren, Gerald (AGRE)" <Gerald.VanBaren at smiths-aerospace.com>:
> >The proper fix is, for your board, change the assignment "vu_long
> >*dummy = 0x00000000;" to point to writable RAM on your board.
>
> This is the purpose of CFG_MEMTEST_SCRATCH.
>
> Please, please read the README, which says:
> "- CFG_MEMTEST_SCRATCH:
>    Scratch address used by the alternate memory test
>    You only need to set this if address zero isn't writeable"
>
> The last statement implies that you DO need to set
> CFG_MEMTEST_SCRATCH if address zero ISN'T writeable.
>
> No need to change any code at all.
>
> Cheers
>  Anders

Hi Anders,

In this case, the patch is hiding a pretty serious misconfiguration.  I
still vote "no" on the patch as proposed.

gvb

******************************************
The following messages are brought to you by the Lawyers' League of
IdioSpeak:

******************************************
The information contained in, or attached to, this e-mail, may contain confidential information and is intended solely for the use of the individual or entity to whom they are addressed and may be subject to legal privilege.  If you have received this e-mail in error you should notify the sender immediately by reply e-mail, delete the message from your system and notify your system manager.  Please do not copy it for any purpose, or disclose its contents to any other person.  The views or opinions presented in this e-mail are solely those of the author and do not necessarily represent those of the company.  The recipient should check this e-mail and any attachments for the presence of viruses.  The company accepts no liability for any damage caused, directly or indirectly, by any virus transmitted in this email.
******************************************