[U-Boot-Users] [PATCH] lpd7a40x register defs, include consolidation

[Wolfgang Denk]

Dear Paul,

in message <200408291907.31904.pruhland at rochester.rr.com> you wrote:
> 
> I know you dislike large patches with many changes but I am hoping you will 
> accept this.  I've changed the register definitions to be in the style 

Indeed. And I really hate it to receive patches that merge  unrelated
changes into one big unseparatable thing.

And this is why I have to reject this one.

> CHANGELOG
> * Patch by Paul Ruhland, 29 August 2004
>   - change register definitions to use the __REG style preferred by the
>     arm linux community

This is OK with me. [1]

>   - add targets to Makefile for all card engine SDRAM configurations
>   - add support for all SDRAM configurations in board config includes,
>     'sdram_init', and board config.mk

No. I reject this. [2] Please do not pollute the Makefile and MAKEALL
(oops, you even forgot to update this one!) with  so  many  different
build  targets  which  differ  only  in the available RAM size of the
target. There is existing code (in common/memsize.c) to  atomatically
detect the available size, so please fix your code and auto-adjust as
needed.  This  will  also make your life easier as a board maintainer
since you need to have only one image per board type, not a different
one for each board configuration.

>   - add CONFIG_LPD7A404 to 'ARM base boards' in toplevel README
>   - add CPLD revision detection to handle hardware variations between
>     card-engine revisions
>   - consolidate existing board config includes into generic 'lpd7a40x-10.h'
>     and 'lpd7a40x.h'... differences between boards are small enough not
>     to warrent seperate files

This is OK with me. [3]

Please feel free to resubmit modifications relating to [1] and [3].

Resubmit [2] after fixing the code.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Defaults are wonderful, just like fire.
                  - Larry Wall in <1996Mar6.004121.27890 at netlabs.com>