[U-Boot-Users] [PATCH] lpd7a40x register defs, include consolidation

[Ruhland, Paul]

Wolfgang,

Thanks for the response.  I will resubmit with necessary changes.

A little info regarding point [2]:

> No. I reject this. [2] Please do not pollute the Makefile and MAKEALL
> (oops, you even forgot to update this one!) with  so  many  different
> build  targets  which  differ  only  in the available RAM size of the
> target. There is existing code (in common/memsize.c) to  atomatically
> detect the available size, so please fix your code and auto-adjust as
> needed.

I had code to autodetect the ram working but I removed it since it required 
changes to several files relating to how the DRAM config is handled (printed, 
passed to kernel, etc).

For configurations with more than 32MB of DRAM the layout is not contiguous, 
ie. more than one bank is required.  Since the number of DRAM banks is 
#defined there is no way to adjust this at runtime.  The result is having an 
extra bank of zero size configured for boards with <= 32MB DRAM.

This gives the wrong impression...that there are more DRAM banks but for some 
reason one is zero size (ie. something is wrong).

I've since booted a kernel with the above setup and it seems to deal with the 
zero size bank fine so I guess this isn't a problem from the operation point 
of view.

It would be nice if either:
1) the number of DRAM banks was configurable at runtime.
2) leave the number of DRAM banks #defined (as max. banks) and simply add 
checks for zero size in the config print, kernel atag, etc. handling to skip 
such banks.

-- 
Paul Ruhland