[U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined

Pantelis Antoniou panto at intracom.gr
Tue Sep 14 10:06:37 CEST 2004


Anders Larsen wrote:
> Pantelis Antoniou <panto at intracom.gr> wrote:
> 
>>--- u-boot/common/serial.c	2004-08-02 01:48:18.000000000 +0300
>>+++ u-boot-cvs-work/common/serial.c	2004-09-07 14:23:44.000000000 +0300
>>@@ -102,6 +102,8 @@
>>{
>>	struct serial_device *s;
>>
>>+	return 0;
>>+
>>	for (s = serial_devices; s; s = s->next)
>>	{
>>		if (strcmp(s->name, name) == 0)
> 
> 
> Hi,
> 
> is it intentional that you disable the body of that function?
> If yes, why not remove it entirely?
> 
> Cheers
>  Anders
> 
> 
> 

OBVIOUSLY IT IS WRONG.

Damn, good catch.

Remove the return 0 please.

Regards

Pantelis







More information about the U-Boot mailing list