[U-Boot-Users] [PATCH] Compact Flash + TI PCI1510 support for MPC8540ADS board

[Zajac Adam-AAZ004]

Wolfgang,

> First some formal reasons:
> 
> * CHANGELOG entry missing
> * Coding Style violations (trailing white space, wrong 
> indentation, etc.)

I'll correct that.

> * You add a cople of new config options (like 
> CONFIG_IDE_CARDBUS_CF_16BIT)
>   without any documentation.

I needed a config option for the compact flash being interfaced on a cardbus
in a legacy 16-bit mode. Have grep'ed the U-Boot sources and couldn't find
anything that would work. I'll need to document that option.

> 
> Technical reasons:
> 
> I think your changes to drivers/ti_pci1410a.c might  have  impact  on
> (read:  will break) existing board support that uses this 
> driver. Did you check this with the previous authors?
> 
> You change the default configuration of the MPC8540ADS board; 
> did you check this with the maintainer of this board?

I'll try to contact the previous authors and consult with them a possible
resolution that wouldn't break any existing configurations. My PCI1410/1510
related changes are based on the recommendations I've received from the TI
FAE. The compact flash related changes are based on the data provided by
SanDisk and SimpleTech FAEs.

I certainly appreciate your feedback.
Regards,

Adam Zajac