[U-Boot-Users] Patch PHY Reset (needed for Marvell 88E1111)

Wolfgang Denk wd at denx.de
Fri Aug 12 23:18:10 CEST 2005


In message <20050624194024.24773.qmail at web30313.mail.mud.yahoo.com> you wrote:
>
> Attached is a patch that preserved the contents of
> PHY_BMCR during a soft reset by only setting the reset
> bit.  This allows the PHY strapping to be preserved. 

Added, thanks.

> The patch also include an enhancement that allows
> overiding of the miiphy_speed and miiphy_duplex
> functions when RGMII is used without PHYs for proper
> MAC configuration.
...
> +/* undefine functions that may have been renamed for a specific board */
> +#ifdef miiphy_speed
> +#undef miiphy_speed
> +#endif
> +#ifdef miiphy_duplex
> +#undef miiphy_duplex
> +#endif

Ummm... me thinks that if these symbols are defined hat there  should
be  some reason for this, and simply undefining those is probably not
a good idea? Maybe I simply don't understand what you have  in  mind.
Rejected for now - please elucidate.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our OS who art in CPU, UNIX be thy name.
Thy programs run, thy syscalls done,
In kernel as it is in user!




More information about the U-Boot mailing list