[U-Boot-Users] Suggestion on flash init

[Wolfgang Denk]

In message <20051225190658.F3F9.LARK at linux.net.cn> you wrote:
> 
> I have tested cfi_flash.c for a while. Unfortuanately, it fails for
> Spansion S29AL016M. The chip can be recognized, chip information is all
> correct, but the erase and write routines fail.

Then please (lets) fix the problem instead of inventing the wheel again.

> And even it is included by multiple files, we can make these variables
> static. Or we can use better solution, but the idea itself is still

That's even worse as it would silently create multiple copies of  the
same data - which is just a waste of precious memory.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is dangerous to be sincere unless you are also stupid.
                                                - George Bernard Shaw