[U-Boot-Users] [PATCH] Refreshed 85xx and 83xx patches

[Wolfgang Denk]

In message <1122660203.7750.24.camel at cashmere.sps.mot.com> you wrote:
> 
> Here is a URL referencing a refresh of all of
> the outstanding 85xx and 83xx U-Boot patches.

Sorry, but I have to reject this monster patch. Please stick  to  the
coding style. A quick scan showed the following problems:

* C++ comments in

	board/mpc8349ads/mpc8349ads.c
	cpu/mpc83xx/pci.c
	doc/README.PIP405
	drivers/sk98lin/skgeinit.c
	drivers/sk98lin/skxmac2.c
	include/configs/MPC8349ADS.h

* Trailing white space in

	common/cmd_flash.c
	common/cmd_usb.c
	common/usb.c
	common/usb_storage.c
	cpu/arm920t/s3c24x0/usb_ohci.c
	cpu/mpc5xxx/usb_ohci.c
	cpu/mpc83xx/pci.c
	cpu/mpc83xx/resetvec.S
	cpu/mpc83xx/spd_sdram.c
	cpu/mpc83xx/speed.c
	cpu/mpc83xx/start.S
	cpu/mpc85xx/spd_sdram.c
	drivers/tsec.c
	include/asm-ppc/e300.h
	include/asm-ppc/i2c.h
	include/asm-ppc/immap_83xx.h
	include/mpc83xx.h

* Indentation not by TAB in

	doc/README.mpc83xxads
	include/asm-ppc/immap_83xx.h
	include/configs/MPC8349ADS.h
	include/configs/MPC8540EVAL.h

* Excessive amount of empty lines in

	board/LEOX/elpt860/README.LEOX
	board/mpc8540eval/mpc8540eval.c
	cpu/arm920t/s3c24x0/usb_ohci.c
	cpu/mpc83xx/spd_sdram.c
	include/asm-ppc/immap_85xx.h
	include/configs/MPC8349ADS.h

* Trailing empty lines in

	board/mpc8349ads/mpc8349ads.c
	cpu/mpc83xx/cpu_init.c
	cpu/mpc83xx/speed.c
	include/spd.h


Also, the patch contains stuff that does not belong into it, like this chunk:

Merge with rsync://git-user@source.denx.net/git/u-boot.git


Please cleanup and resubmit.



Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A person with one watch knows what time it  is;  a  person  with  two
watches is never sure.                                       Proverb