[U-Boot-Users] [PATCH] limit length of kernel command line in bootm

[Wolfgang Denk]

In message <29494.1120119515 at gerd> you wrote:
>
> This patch limits the length of the command line that the bootm command will
> pass to the kernel. Note that as it stands, it uses CFG_BARGSIZE which must
> be <= the size of the command line array used in the kernel (most boards have
> this set to CFG_CBSIZE, which in turn is usually 256 - which is usually ok).
> I use 1024 for both, and have a kernel patch which increases the command line
> aray to 1024. Cheers!

I don't see any improvement by this patch,  as  you  cannot  know  in
U-Boot  which value is correct for the kernel image you are booting -
ther eis no way to "ask" the kernel for this. So your patch may cause
booting to fail in situtations where it should work,  or  not  detect
problems  when  they  are  there.  In  other  words,  I don;t see any
improvement  over  the  current  situation   which   has   the   same
expectation: that the user knows what he is doing. Also, a hard coded
limit is probably a bad approach anyhow.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Severe culture shock results when experts from another protocol suite
[...] try to read OSI documents. The term "osified" is used to  refer
to  such  documents. [...] Any relationship to the word "ossified" is
purely intentional.                                - Marshall T. Rose