[U-Boot-Users] [PATCH] Differing gcc version ARM options

Wolfgang Denk wd at denx.de
Thu Jun 30 13:21:49 CEST 2005

In message <89A528FE6DB0FA44877BB2F05B846718029D0501 at ZIPPY.Emea.Arm.com> you wrote:
> 	Attached a patch to fix the problems with different ARM options in
> different gcc versions.
> Thanks to Catalin Marinas for suggesting use of the cc-option shell
> function from the kernel make files
> - makes it neater than my last try.....
> Patched against head 30th June 2005.
> Tested with MAKEALL arm.
>    * Patch by Peter Pearse, 30th June 2005
> 	- Import cc-option shell function from kernel
> 	- Use it to get the correct ARM gcc options 
> 	- Supply recommended flags for ARM supplied & supported development
> boards.

Can you please split this patch into independent parts, and re-submit
it in a less cryptic format?  Hiding  a  tarball  in  a  file  called
".patch" is not exactly helpful.

Note that I will reject the part of the patch that adds stuff like this:

+# These values intentionally override all other settings e.g. those from 
+# <UBOOT_ROOT>/config.mk
+# <UBOOT_ROOT>/arm_config.mk
+# <UBOOT_ROOT>/cpuarm<cpu id>/config.mk

to some boards. Compiler options in U-Boot shall depend  on  the  CPU
only,  and  all  boards  with  this processor shall use the very same
options. Otherwise we will run into a maintenance nightmare  when  it
comes to toolchain problems.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You shouldn't make my toaster angry." - Household security explained
in "Johnny Quest"

More information about the U-Boot mailing list