[U-Boot-Users] [PATCH] limit length of kernel command line in bootm

Wolfgang Denk wd at denx.de
Thu Jun 30 15:51:24 CEST 2005

In message <7976.1120138625 at huldra> you wrote:
> >So your patch may cause
> >booting to fail in situtations where it should work,  or  not  detect
> >problems  when  they  are  there.
> On the contrary, it detects a specific situation where it knows the kernel
> will crash and burn without any obvious reason and refuses to boot, after
> outputting a clear error message.

How can it know that|  The  image  may  contain  a  kernel  that  was
adjusted appropriately?

IMHO it's not a good idea  to  enforce  a  boot  loader  update  just
because a number in the kernel configuration changes.

> Yes, indeed - they know what they are doing, and they will ensure that the
> correct number is put in their board config .h file.

This is  unacceptable  for  me.  Kernel  and  boot  loader  shall  be
independent  as  far  as  possible.  Even  on  the  risk  of  using a
combination that does not work.

> The size of the Linux kernel command line array is hardcoded in a number
> of places in the kernel (I know, because I have a patch which increases its

Then let's not make the same error again.

> This patch at least catches one case where it knows the size has been
> exceeded. Since the "bootargs" variable is a variable length string,

It does not know this. It CANNOT know this, as it has no  information
what  I'm  going to load. Actually it might be 2.8 kernel without any
such limitation at all.

Sorry, but I reject this patch as I consider it conceptually broken.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Never face facts; if you do, you'll never get up in the morning."
- Marlo Thomas

More information about the U-Boot mailing list