[U-Boot-Users] Re: Your patch NAND READ.JFFS2S

[Wolfgang Denk]

[I'm not sure which message this is a Re: to, as I haven't  seen  any
message(s) with this subject (yet?)]


In message <42384865.5080100 at fsforth.de> you wrote:
> 
> you are right, the } has to be moved also.
> So the correct patch is:
> 
>             else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) {
>                 cmd |= NANDRW_JFFS2;    /* skip bad blocks (on read too) */
>                 if (cmd & NANDRW_READ)
>                     cmd |= NANDRW_JFFS2_SKIP;    /* skip bad blocks (on
>   read too) */
>    +        }
>    +        else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2))
>    +            cmd |= NANDRW_JFFS2;    /* skip bad blocks */

I woould reject this because it is violating the coding style.
['}' and 'else' on the same line; indentation by TAB].