[U-Boot-Users] OCOTEA get_timer() bug

Wolfgang Denk wd at denx.de
Mon Mar 28 21:58:46 CEST 2005


In message <42485A32.6090501 at mc.com> you wrote:
> I found this bug a while ago and have finally gotten around to looking 
> at it because I needed its service.
> 
> In previous posts to this email list, Wolfgang had mentioned that the 
> "time unit" returned by get_timer() is 1 msec.  Close examination of 
> interrupt_init_cpu() at cpu/ppc4xx/interrupts.c suggests a timer 
> interval setup of 10 msec!

I think you are right.

> I've tested the following and propose it as a fix, replace this:
>    val = gd->bd->bi_intfreq/100;	 /* 10 msec */
> with:
>    val = gd->bd->bi_intfreq/1000; /* 1 msec */
> 
> I've also tested some of the network related functions to insure that no 
> timeout conditions have appeared.
> 
> I want to post this patch but would prefer a code review from those that 
> are more familiar with get_timer() use within the OCOTEA codebase.

I don't know why the 440 is handled separately.

Stefan, do you have an idea?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You know that feeling when you're leaning back  on  a  stool  and  it
starts to tip over? Well, that's how I feel all the time.
- Steven Wright




More information about the U-Boot mailing list