[U-Boot-Users] OCOTEA get_timer() bug
awozniak at mc.com
Wed Mar 30 01:17:45 CEST 2005
My only concern with the fix is that it will break something else that
assumes the timer interval to be 10msec. There are a few "files" that
depend on it for timeout operations:
if ((time_now - time_start) > 3000) <--- 30 sec timo?
bp->bp_secs = htons(get_timer(0) / CFG_HZ);
BootpID += get_timer(0);
TftpOurPort = 1024 + (get_timer(0) % 3072);
Stefan Roese wrote:
> On Monday 28 March 2005 21:58, Wolfgang Denk wrote:
>>>I've tested the following and propose it as a fix, replace this:
>>> val = gd->bd->bi_intfreq/100; /* 10 msec */
>>> val = gd->bd->bi_intfreq/1000; /* 1 msec */
>>>I've also tested some of the network related functions to insure that no
>>>timeout conditions have appeared.
>>>I want to post this patch but would prefer a code review from those that
>>>are more familiar with get_timer() use within the OCOTEA codebase.
>>I don't know why the 440 is handled separately.
>>Stefan, do you have an idea?
> No. The 440 port was done by Scott McNutt <smcnutt at artsyncp.com>, if I
> remember right. But it seems that the fix is correct. Scott (or any other 440
> users), any comments on this?
> Best regards,
More information about the U-Boot