[U-Boot-Users] OCOTEA get_timer() bug

[Andrew Wozniak]

Hello Stefan,

Testing on a real OCOTEA board will be a great help.

Our target is a custom 440gx board with an OCOTEA port of U-Boot. I will 
try to do some testing to determine if there are any side affects on our 
board.

-andrew

Stefan Roese wrote:
> Hello,
> 
> On Wednesday 30 March 2005 01:17, Andrew Wozniak wrote:
> 
> 
>>My only concern with the fix is that it will break something else that
>>assumes the timer interval to be 10msec.  There are a few "files" that
>>depend on it for timeout operations:
>>
>>cpu/ppc4xx/440gx_enet.c
>>          if ((time_now - time_start) > 3000)   <--- 30 sec timo?
> 
> 
> This is 440 specific, but in the comments a few lines above 3 seconds timeout 
> is mentioned. So even this seems to be a bug with a 10 ms timer interval.
> 
> 
>>net/bootp.c
>>	bp->bp_secs = htons(get_timer(0) / CFG_HZ);
>>	...
>>         BootpID += get_timer(0);
>>
>>net/tftp.c
>>	TftpOurPort = 1024 + (get_timer(0) % 3072);
>>
>>net/net.c
>>post/rtc.c
>>tools/updater/flash_hw.c
> 
> 
> All this is generic code (not 440 spcific), so a 1 ms timer interval is 
> assumed.
> 
> Give me a few days and I will test it on an OCOTEA board.
> 
> Best regards,
> Stefan
>