[U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support

Wolfgang Denk wd at denx.de
Tue May 17 16:53:30 CEST 2005


In message <4289FE13.7040708 at moreton.com.au> you wrote:
>
> Attached is a patch that adds support to u-boot for the Kendin/Micrel
> KS8695P CPU. It is an ARM9 based SoC type device, used in a lot of
> little routers.
> 
> This patch was originally generated against u-boot 1.1.1.

Sorry, but your source base is just too old, and the patch as  is  is
not  usable  any  more.  Please  note  that  there  has  been a major
reorganisation to better support SoC systems like yours, too. Instead
of duplicationg the same code again and again we now share the common
parts.

Please rework your patch; do not create a  new  cpu/  directory,  but
instead  a  new  SoC-specific subdirectory like those already present
for at91rm9200 or s3c24x0 systems.


And please don't forget  to  include  the  required  entries  to  the
CHANGELOG, MAINTAINERS and CREDITS files.


> I am following up this patch with a couple of more patches that
> add support for the OpenGear CM4008 and CM4116/CM4148 console
> manager boards (that use the KS8695P CPU).

Actually the order was different, but this doesn't matter:  all  your
patches share the same problem. Please fix, and resubmit.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Why waste negative entropy on comments, when you could use the  same
entropy to create bugs instead?"                        - Steve Elias




More information about the U-Boot mailing list