[U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support

Greg Ungerer gerg at moreton.com.au
Tue May 24 08:45:19 CEST 2005


Hi Wolfgang,

Wolfgang Denk wrote:
> In message <42913054.3010901 at moreton.com.au> you wrote:
> 
>>Ok, it makes no sense (at least currently) to be compiling this driver
>>for any configuration not based on the KS8695 CPU. So the simple fix
>>is to define it out.
> 
> 
> Atually I think it makes sense to compile the driver only  for  those
> boards  that  enable  it,  as ther ecould be even KS8695 based boards
> that don't need / want to use this driver.
> 
> Fixed that wat. Thanks.

Yes, that is true.

BTW, we could split out the defines specific to the ethernet driver
from that arch-ks8695/platform.h if that made sense. As it is currently
that platform.h is a direct copy of that file from the Linux support
for this device. It would be sorta nice if we can keep it that way,
no doubt it will get updated over time as KS release new parts in this
family (they have 3 in this CPU family currently).

Regards
Greg




More information about the U-Boot mailing list