[U-Boot-Users] Re: [PATCH] Make target for all ARM supplied and supported development boards - patch 007

Catalin Marinas catalin.marinas at arm.com
Mon Oct 10 11:22:53 CEST 2005


Wolfgang Denk <wd at denx.de> wrote:
> in message <tnxbr21v0no.fsf at arm.com> you wrote:
>>
>> A suggestion - since you are using GIT, you could automatically
>> generate the changelog from the patch comments and no longer keep this
>
> I would still need to copy & paste the information from the  message,
> and collect submitter name and date from the mail headers. I think it
> is impoortant to be able to match a change to the original posting of
> the submitter on the mailing list.

Scripts like 'git applymbox' or 'stg import --mail' can do this
automatically. With StGIT you can even modify the patch multiple times
before you decide to permanently store it in your repository.

> In this respect, the CHANGELOG entry is a condensed form of the patch
> comments with additional information about  the  sugbmitter  which  I
> need  in  any  case  -  no  matter  if I explicitely register it in a
> CHANGELOG file or not.
[...]
> Please note that I also continue to keep the CVS server at SF in sync
> with all  development  going  on  on  the  main  branch  of  the  git
> repository.  This  is another place where the CHANGELOG file comes in
> handy.

You have a pre-commit hook in GIT which you can use to automatically
append part of the patch description and author to the changelog file
(like for Linux, you can ask people to have a short description on the
first line or two, followed by an empty line and followed by a longer
description).

> Also,  I  am  strictly  against  automatically  importing   unchecked
> patches. Too many patches contain horrible nonsense and would basicly
> corrupt  the repository. And if I have to process / filter the paches
> anyway, then it does not make any difference if I run this command or
> that one.

Nobody prevents you from looking at the patch before applying it, or
for applying it on a development branch and just moving it to the
stable one (or just temporary applying them with StGIT and, if they
prove to be OK, 'stg commit' to store them permanently).

> But thanks for the well-meant suggestion.

All that matters is how you are used to work, it's pretty hard to
change the work-flow after using it for years. Anyway, in case you
want to automate the patch importing, I can help you with some
scripts (or StGIT advice).

Regards,

-- 
Catalin





More information about the U-Boot mailing list