[U-Boot-Users] [PATCH] wrong lcd splashscreen colors (pxa)

[Wolfgang Denk]

In message <43299EC6.6050206 at primaelectronics.com> you wrote:
> 
> it seems that the computation of colors in
> common/lcd.c:lcd_display_bitmap() is wrong for green and blue

It's working fine on all the PowerPC systems where I am able to test.

> components. I checked on version 1.1.3 and on cvs.sf.net.
> 
> I'm working on a PXA270 but this seems general (as far as I understand).

Probably not general, but maybe byte-order dependent ?

> 
> ------------------------------------------------------
>                         bmp_color_table_entry_t cte = bmp->color_table[i];
>                         ushort colreg =
>                                 ( ((cte.red)   << 8) & 0xf800) |
> -                               ( ((cte.green) << 4) & 0x07e0) |
> -                               ( (cte.blue) & 0x001f) ;
> +                               ( ((cte.green) << 3) & 0x07e0) |
> +                               ( ((cte.blue)  >> 3) & 0x001f) ;
> 

Please see section "Submitting Patches" in the README. In  this  form
this  is  not  acceptable.  Also  make  sure  that  you  don't  break
big-endian systems with your modification.

> Thank you all for the great job: it's the first time I get to a
> bootloader prompt (on a new hardware) after only about 6 hours of work.

Congrats!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Is the glass half empty, half full, or twice as large as it needs to