[U-Boot-Users] [PATCH] computation of framebuffer palette for 8bpp lcd bitmaps

Wolfgang Denk wd at denx.de
Wed Sep 21 15:28:02 CEST 2005


Dear Francesco,

in message <432ACE30.9000504 at primaelectronics.com> you wrote:
> 
> -- CHANGELOG entry
> 
> * Corrected the computation of framebuffer palette for 8bpp lcd bitmaps
>   Patch by Francesco Mandracci, 16 Sep 2005

Thank  you  very  much  for  the  semi-perfect  patch!  I  wisch  all
submissions would be that clear and well documented.

There is only one problem:

> -- The patch itself:

It does not apply...

> -                               ( ((cte.green) << 4) & 0x07e0) |
> -                               ( (cte.blue) & 0x001f) ;
> +                               ( ((cte.green) << 3) & 0x07e0) |
> +                               ( ((cte.blue)  >> 3) & 0x001f) ;

Something (probably your mailer) crippled the white  space  (expanded
the TABs in the original source).

Applied manually, but please note this for future submissions.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1st Old Man:  Gee, its windy today.
2nd Old Man:  No it's not... it's Thursday.
3rd Old Man:  Yeh, me too.  Let's go for a beer.




More information about the U-Boot mailing list