[U-Boot-Users] common/cmd_mii.c bug and patch

Wolfgang Denk wd at denx.de
Sat Sep 24 22:01:36 CEST 2005

In message <c166aa9f04122820342e4a5c55 at mail.gmail.com> you wrote:
> The mii info command (the !CONFIG_TERSE_MII version)
> has a bug in current cvs. If the phy address is passed
> to the command the code assigns the variable addr to start,
> instead of the values of addrlo which is extracted from the
> command line.  At that point in the code addr is always 0.

Added, thanks. But please don;t forget to include a CHANGELOG entry!

> Also in this file on lines 55 and 418 there are two places
> where a call to mii_init() is conditionally compiled in, but 
> one condition includes defined(CONFIG_MCF52x2) and the
> other doesn't.  Is this intentional?

Probably not, but I don't have any MCF52x2 systems to test.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The whole world is about three drinks behind."     - Humphrey Bogart

More information about the U-Boot mailing list