[U-Boot-Users] [Patch]IntegratorAP & CP multi core module support
wd at denx.de
Sun Sep 25 02:04:20 CEST 2005
In message <89A528FE6DB0FA44877BB2F05B84671801C12D3C at ZIPPY.Emea.Arm.com> you wrote:
> Please inform me of any defects found.
See below :-(
> * Patch by Peter Pearse, 2 Feb 2005
> - add core module targets
> - add ARM946E cpu support
> - remap memory to 0x00000000
I finally added this patch, but just because it's been on my queue
for so long without any real progress. I hope this is the easiest way
to get things going.
But PLEASE don't even think of submitting such a monster again.
Most of your files violate the Coding Style. Trailing white space,
What you do tho the Makefile is horror. Adding 170+ lines just for a
few boards? There should be a cleaner way! Please provide a
(incremental) patch to get rid of this mess! The Makefile is a
Makefile, and no place to add hundrets of lines of source code.
Your board config names are unacceptable. "integratorcp_CM922T_XA10".
Who is supposed to type something like this? Please provide a
(incremental) patch to use sensible, *much* shorter names. Instead of
"integratorcp_CM922T_XA10" it should be sufficient to write
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In C we had to code our own bugs, in C++ we can inherit them.
More information about the U-Boot