Fw: [U-Boot-Users] [PATCH] Fix for configuration has both dataflash and parallel flash

[Wang Jian]

Hi Denk,

You really need to look at this patch.

Forwarded by Wang Jian <lark at linux.net.cn>
----------------------- Original Message -----------------------
From:    Wang Jian <lark at linux.net.cn>
To:      u-boot-users at lists.sourceforge.net
Date:    Mon, 03 Apr 2006 15:22:31 +0800
Subject: [U-Boot-Users] [PATCH] Fix for configuration has both dataflash and parallel flash
----

Hi,

When the board has both dataflash and parallel flash, using 'cp' command
will write to parallel flash and then fail.

The patch below fixes the problem. BTW, I think "addr" is typo of "dest"
in the dataflash test, so the patch may be as simple as s/addr/dest/ in
dataflash test. I am in a hurry, so let suitable person to decide.

diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index 0f4f9b7..a01c2a5 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -423,6 +423,7 @@ int do_mem_cp ( cmd_tbl_t *cmdtp, int fl
        /* check if we are copying to Flash */
        if ( (addr2info(dest) != NULL)
 #ifdef CONFIG_HAS_DATAFLASH
+          && (!addr_dataflash(dest))
           && (!addr_dataflash(addr))
 #endif
           ) {



-- 
  lark



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

--------------------- Original Message Ends --------------------