[U-Boot-Users] [PATCH 05/08]: mpc7448hpc2 board flash support

[Zang Roy-r61911]

> > > I will not accept such code duplication.
> > 
> > There are some differences. Another reason I keep the driver in my 
> > board
> 
> Differences are  small  compared  to  the  toal  size  of  the  file.
> Duplication  is always bad, as it will cause a maintenance nightmare.
> It may slip though occasionally, but when I get aware of  it  
> I  will not accept such duplicated code.
> 

I will erase the duplication. I never intend to slip though.

> > directory
> > is that I do not want to affect other board behavior. At 
> lease, I am 
> > not sure.
> 
> Submit a patch on the list for testing?

No, They are not for testing. I have tested them thousands of times :).
My original intend is 
to keep the code in my board directory..
 

> > Is it right that I add some "ifdef BOARD_BYPE" in the 
> general driver 
> > code?
> 
> There must be no board dependent code in the CFI driver. If 
> you  want to  add  support for a special feature, use some 
> CFG_HAVE_FEATURE_FOO or the like, but only when *really* necessary.
> 
> Normally, the need for such  a  feature  in  the  CFI  driver 
>  is  an indication of some design error on your side.

The difference is caused by ENDIAN issue.  Anyway, I will consider it
carefully. 

> 
> > Should I move the tsi108 feature to the general directory 
> or just keep 
> > it in my board directory?
> 
> Please move to the drivers directory.

OK, I will collect the feedback and refine my code.
Thanks.
Roy