[U-Boot-Users] [PATCH] for FLASH sector info reverse order & NS16550 pre-setting PSR

[Wolfgang Denk]

In message <loom.20060801T051614-40 at post.gmane.org> you wrote:
> HI:
>     I use a 8MB TOP FLASH, with CFI driver can not handle this type, becasue 
> SECT info order is for BOTTOM FLASH, so I modefied for it. Next version can 
> detect bootloc :-)

I think I'll wait for the next version then. Having code with  #ifdef
CFG_FLASH_SECT_INFO_REVS  in  the  generic  CFI  driver  seems not so
attractive to me.

Also, I reject your patch for formal reasons:

* There is no CHANGELOG entry.

* You submit unrelated changes in a single patch.

* Your patch adds trailing white space.

* Code like this:

>   			tmp = flash_read_long (info, 0,
>   					       FLASH_OFFSET_ERASE_REGIONS +
> ! #ifdef CFG_FLASH_SECT_INFO_REVS
> ! 					       (num_erase_regions - i - 1) *
> ! #else
> ! 					       i * 
> ! #endif
> ! 					       4);

  is unreadable and will not be accepted.

* Ummm... is this PSR or FCR ?

> + #ifdef CFG_NS16550A_PSR
> + 	com_port->fcr = CFG_NS16550A_PSR;
> + #endif

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why don't you have a Linux partition installed so you can be  working
in  a  programmer-friendly environment instead of a keep-gates'-bank-
account-happy one? :-)                            -- Tom Christiansen