[U-Boot-Users] [Patch01]AS352X:U-Boot1.1.6 patch 1 for AS352X SOC

Wolfgang Denk wd at denx.de
Sat Dec 2 01:40:06 CET 2006


Thomas,

in message <2ECBC2365E331640B5BC8FBE829192A3013B586F at SUX2119.office.amsiag.com> you wrote:
>
> 	U-Boot1.1.6 for AS352X
> Port to U-boot to New ARM base SOC AS352X, support NAND flash Boot.
> Part 1:

I told you before that your mailer is wrapping long lines, which
corrupts your patches. And you just did it again:

...
> +/* For sake of completness and for easier exchanging of round-up and
> round-down 
^^^^^^^^^^^^
> +divisions provide also a round-down macro */
> +
> +#define DIVIDE_AND_ROUND_DOWN( a , b ) ((a)/(b))
> +
> +/* Macro which evaluates to the absolute value of an integer value*/
> +#define ABS(A) (((A)>0)?(A):(-(A)))
> +
> +/* ------------------------defines for Dynamic Mem
> --------------------------- */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
> +#define AS352X_MPMC_DYCNTL    AS352X_SDRAM_BASE_ADDR( 0x20  )
> +#define AS352X_MPMC_DYREF     AS352X_SDRAM_BASE_ADDR( 0x24  )
> +
> +/* ------------------ MT48LC4M16A2 SDRAM & MT48LC32M16A2 SDRAM
> --------------------------- */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is not usable:

	-> patch -p1 --dry-run </tmp/patch
	patching file board/as352xpb/as352xpb.c
	patch: **** malformed patch at line 48: */

All your patches are corrupted. AND I TOLD YOU BEFORE.

Rejected.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The combination of a number of things to make existence worthwhile."
"Yes, the philosophy of 'none,' meaning 'all.'"
	-- Spock and Lincoln, "The Savage Curtain", stardate 5906.4




More information about the U-Boot mailing list