[U-Boot-Users] [Patch01]AS352X:U-Boot1.1.6 patch 1 for AS352X SOC(New)

Wolfgang Denk wd at denx.de
Sat Dec 2 22:26:49 CET 2006


Thomas,

in message <008a01c7161f$48904480$6507a8c0 at 228fd4981e4b4dc> you wrote:
> 
> From:thomas.luo at ieee.org
> U-Boot1.1.6 for AS352X
> Port to U-boot to New ARM base SOC AS352X, support NAND flash Boot.
> please ref:
> http://www.austriamicrosystems.com/03products/products_detail/AS3525/AS3525.htm
> Part 1:
> 

This is the third time you are submitting this. And it is the third
time I have to ask you to clean up your code before posting.

Did you bother to read my messages? Do you remember this:

------- Forwarded Message

Date:    Fri, 01 Dec 2006 10:19:35 +0100
From:    Wolfgang Denk <wd at denx.de>
To:      "Luo Thomas" <Thomas.Luo at austriamicrosystems.com>
Subject: Re: [Patch]U-Boot1.1.6 for AS352X 

...
First, you should clean up your code and fix at least the following
problems:
...
* You violate the coding style in  *many*  places  (indentation,  C++
  comments,  indentation  not  by  TABs,  trailing  white space, line
  length, brace style, ...)
...

------- End of Forwarded Message

I hereby reject your patch(es) because you did  not  clean  up  these
problems.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Successful and fortunate crime is called virtue.             - Seneca




More information about the U-Boot mailing list