[U-Boot-Users] Breakage of board ports on new features.

[Wolfgang Denk]

In message <14A6A69F-9B58-42AB-985A-89F70DEB05A6 at kernel.crashing.org> you wrote:
> 
> Are you ok with having CONFIG_MPC8349 set in tqm834x.h?

Yes, definitely.

> So how should we set this for TQM834x?  Clearly MPC8349EMDS shouldn't  
> have it set, and MPC8349ITX should by your current description.

TQM834x in it's current state should set CONFIG_MPC8349 as it was
implemented and tested with MPC8349 only in mind. 

> Also, let me ask, what exactly does CONFIG_MPC8349 mean?  Does it  

It means that the board has a MPC8349 CPU mounted.

> Personally, I feel that defining it before it's clear there is a user  
> that needs it lends the define to be incorrectly used in the future.

For example, I use it for looking for boards with a specific  CPU  on
it (by grepping in include/configs/ :-)

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multimedia:
You have nice graphics, sound and animations when the system crashes.