[U-Boot-Users] [PATCH] 83xx: Put the version (and magic) after the HRCW.

[Jerry Van Baren]

Joakim Tjernlund wrote:
>> Sam Song wrote:
>>> Jerry Van Baren <gerald.vanbaren at comcast.net> wrote:
>>>> Put the version (and magic) after the HRCW.  This
>>>> puts it in a fixed location in flash, not at the
>>> start 
>>>> of flash but as close as we can get.
>>> Nice effort. Space saving and better version check.
>>>
>>> I guess the same change could apply for MPC8260/47/8.
>>>
>>> Thanks,
>>>
>>> Sam
>> Yes.  Most boards have the version in the first bytes of 
>> flash, but this
>> was not possible on the 82xx because of the HRCW, so it was put in
>> .data.  This set up was copied for the 83xx (which also has a 
>> HRCW).  My
>> change moves it back to .text just after the HRCW.  I put also the
>> u-boot magic number back in in honor of Wolfgang. ;-)
>>
>> If you change the file names in the patch, it probably would 
>> apply.  :-)
>>  I intend to do this (perhaps literally), but ran out of 
>> ambition tonight.
>>
> 
> Looks almost the same as the patch I sent the other day. I am good
> with either version.
> 
>  Jocke

Hi Jocke,

Yes, your patch, and my objection to its removal of the HRCW, was the 
genesis of this one.  The two differences are (a) I kept the HRCW and 
(b) I put the "u-boot magic number" in (no known reason to do this, but 
it Just Seemed Right[tm]).  The result of (b) is that the version starts 
at flash offset 0x44 rather than 0x40.  Should be NBD.

Thanks,
gvb