[U-Boot-Users] builtin OF tree dtb gone

[Wolfgang Denk]

Dear Joakim,

in message <1166378632.30422.98.camel at gentoo-jocke.transmode.se> you wrote:
>
> how about this patch:

Sorry, but there are two things I don't like:

> Make it possible to use a OF tree embedded in u-boot.
> Also make sure OF tree is below 8MB.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> 
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 7aae8a6..78f8d15 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -531,8 +531,12 @@ do_bootm_linux (cmd_tbl_t *cmdtp, int fl
>  	image_header_t *hdr = &header;
>  #ifdef CONFIG_OF_FLAT_TREE
>  	char	*of_flat_tree = NULL;
> +#ifdef CFG_EMBEDDED_FLAT_TREE

I don't want to have another #ifdef here. It should be possible to do
this (for example in the linker script) without this.

> -#ifndef CFG_NO_FLASH
> -			if (addr2info((ulong)of_flat_tree) != NULL)
> +		   if (of_flat_tree >= (char *) (8*1024*1024))

And  I  definitely  reject  such  hard-wired  and  uncommented  magic
constants which are wrong on most of the systems.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In general, they do what you want, unless you want consistency.
                                    - Larry Wall in the perl man page