[U-Boot-Users] Bug fix on cmd_nand.c

chaidy at lenovo.com chaidy at lenovo.com
Mon Jan 16 11:12:17 CET 2006


Hello, Wolfgang!

I found two bugs in common/cmd_nand.c when debugging nand flash, which
is from u-boot-1.1.4 and the same with git tree:

1. there are 3 places using "not exact" or "wrong" parameters in 
strncmp() function.

strncmp(cmdtail, ".oob", 2)    ==> strncmp(cmdtail, ".oob", 4)
strncmp(cmdtail, ".jffs2", 2)  ==> strncmp(cmdtail, ".jffs2", 6)
strncmp(cmdtail, ".jffs2s", 2) ==> strncmp(cmdtail, ".jffs2s", 7)

2. "nand read.jffs2" command will bypass "nand read.jffs2s" command
for the else-if branch.

FYI, the attachment is a diff patch with "-purN" options.

Best regards,
Dongyan Chai


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20060116/d6fbc958/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_nand.diff
Type: application/octet-stream
Size: 1144 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060116/d6fbc958/attachment.obj 


More information about the U-Boot mailing list