[U-Boot-Users] problems with spartan3, spartan2 and virtex2 relocation of null pointers

[Wolfgang Denk]

In message <c166aa9f0607151744h32ef3f75h270d0fe8562582c3 at mail.gmail.com> you wrote:
> 
> The relocation code that moves the pointers never checks them for null
> and happily adds reloc_offset to the null pointers making non-null
> ones and leading to a crash when the code tries to call them.

Argh...

> Does it make more sense to remove the checks and always call the
> functions (assuming everybody using these bits has defined at least a
> stub for these), or does it make more sense to test the pointers at
> reloc time and fix all the reloc functions?

Relocation should be performed as expected, i. e. here the relocation
code should be fixed.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A stone was placed at a ford in a river with the inscription:
"When this stone is covered it is dangerous to ford here."