[U-Boot-Users] [DNX#2006060842000028] [patch] Add support for CONFIG_SERI [...]
DENX Support System
support at denx.de
Wed Jul 19 13:40:01 CEST 2006
Hello list,
inside the automatic U-Boot patch tracking system a follow up
to [DNX#2006060842000028] was entered through the web interface:
<snip>
> In message
> <47F3F98010FF784EBEE6526EAAB078D1024F8108 at tq-mailsrv.tq-net.de> you
> wrote:
> >
> > This patch supports two serial consoles on boards with a MPC5xxx CPU.
> > The console could be switchd during runtime by setting stdin, stdout
> > and stderr to the desired serial interface (serial0 or serial1).
> > Which PSCs are used for the console is definded by CONFIG_PSC_CONSOLE
> > and CONFIG_PSC_CONSOLE2. For further Information see README.serial_multi
> >
> > Signed-of-by: Martin Krause <martin.krause at tqs.de>
> >
> > CHANGELOG:
> >
> > * Add support for CONFIG_SERIAL_MULTI on MPC5xxx
> > Patch by Martin Krause, 8 Jun 2006
>
> Sorry, but this patch conflicts with recent changes that also add
> support for alternative console ports on MPC5200 systems. Also,
> please try to avoids code like this which is ugly and unreadable -
> try using an index:
>
> #if defined(CONFIG_SERIAL_MULTI)
> #if CONFIG_PSC_CONSOLE2 == 1
> #define PSC_BASE2 MPC5XXX_PSC1
> #elif CONFIG_PSC_CONSOLE2 == 2
> #define PSC_BASE2 MPC5XXX_PSC2
> #elif CONFIG_PSC_CONSOLE2 == 3
> #define PSC_BASE2 MPC5XXX_PSC3
> #elif defined(CONFIG_MGT5100)
> #error CONFIG_PSC_CONSOLE2 must be in 1, 2 or 3
> #elif CONFIG_PSC_CONSOLE2 == 4
> #define PSC_BASE2 MPC5XXX_PSC4
> #elif CONFIG_PSC_CONSOLE2 == 5
> #define PSC_BASE2 MPC5XXX_PSC5
> #elif CONFIG_PSC_CONSOLE2 == 6
> #define PSC_BASE2 MPC5XXX_PSC6
> #else
> #error CONFIG_PSC_CONSOLE2 must be in 1 ... 6
> #endif
> #endif /* CONFIG_SERIAL_MULTI */
>
> Please clean up adn resubmit.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> Software Engineering: Embedded and Realtime Systems, Embedded Linux
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Pray to God, but keep rowing to shore. - Russian Proverb
</snip>
Your U-Boot support team
More information about the U-Boot
mailing list