[U-Boot-Users] parse bug in cmd_mii.c

Wolfgang Denk wd at denx.de
Sat Jul 22 20:39:08 CEST 2006


In message <c166aa9f0506131006ba8f552 at mail.gmail.com> you wrote:
> I noticed that in do_mii() the code is dereferencing argv[1] without
> checking what value argc has.  This leads to an exception if a command
> line like 'mii ' is given where argv[1] is NULL.

Finxed. Thanks for pointing out.

> I have a patch, but my cmd_mii.c is carrying around some other patches
> (some submitted to the list, some local).  Is there a good way to
> separate out the patches I want to submit by themselves?

This depends on the tools you use. git cherry piking comes  to  mind,
or some of the git porcelains...

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One day," said a dull voice from down below, "I'm going to  be  back
in  form again and you're going to be very sorry you said that. For a
very long time. I might even go so far as to make even more Time just
for you to be sorry in."              - Terry Pratchett, _Small Gods_




More information about the U-Boot mailing list