[U-Boot-Users] [PATCH] revised word alignment fixes for word aligned NS16550 UART

Wolfgang Denk wd at denx.de
Sun Mar 12 01:21:58 CET 2006


In message <OFF26F609C.4348B979-ONC1256FB7.004C4EC9-C1256FB7.0058F5C8 at philips.com> you wrote:
> 
> CHANGELOG:
> * Patch by Jean-Paul Saman, 23 Feb 2005
> 
> - include/ns16550.h 
> Fixes alignement bug with UART that only supports word aligned access:
> removed "__attribute__ ((packed));" for "(CFG_NS16550_REG_SIZE == 4)" 
> GCC generates bytes access when it encounters the packed attribute 
> regardless if the struct is already word aligned for a platform. 
> Peripherals that can only handle word aligned access won't work properly 
> when accessed with byte access. The struct NS16550 is already word aligned 
> for REG_SIZE = 4, so there is no need to packed the struct in that case.

Applied. Thanks.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Misquotation is, in fact, the pride and privilege of the  learned.  A
widely-read  man  never  quotes  accurately,  for  the rather obvious
reason that he has read too widely.
                - Hesketh Pearson _Common Misquotations_ introduction




More information about the U-Boot mailing list