[U-Boot-Users] Pre-loader for the avnet5282 board

Wolfgang Denk wd at denx.de
Wed Mar 15 16:06:20 CET 2006

In message <002d01c64800$80393330$091a1bac at serra.es> you wrote:
> This patch add a pre-loader for the avnet5282 board.

Many filkes of this code do not cointain  any  Copyright  statements,
and  none  of  them  has  any indication about which license applies.
Before we can add any code it must be clear that it comes with a  GPL
compatible license.

Also, this code duplicates a  lot  of  existing  functionality,  like
serial  drivers  and  all  this.  Also  some  header  files look like
duplicates of existing ones. This is not  acceptable.  Please  re-use
the existing code.

Your code also violates the  Coding  Style  requirements  in  several
aspects. You have to clean up your code.

Make sure that all files are actually text files, i. e. all lines and
with a newline character.

Finally, scripts like your "gdbinit.load", "gdbinit.reset" etc.  have
no place in this code. Pleas remove these.

Sorry, I have to reject this patch.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A consultant is a person who borrows your watch, tells you what  time
it is, pockets the watch, and sends you a bill for it.

More information about the U-Boot mailing list