[DNX#2006033142000356] [U-Boot-Users] [PATCH] notes on cpu/mips/config.mk [...]

[DENX Support System]

Hello list,

inside the automatic U-Boot patch tracking system a new ticket
[DNX#2006033142000356] was created:

<snip>
> Hello,
> 
> I have a mips based board and during u-boot support developing I
> notice that in file «cpu/mips/config.mk»:
> 
> * should be replaced this line 
> 
>    -mips-linux-as --version|grep "GNU assembler"|awk '{print $$3}'|awk
> -F . '{print $$2}')
>    +$(AS) --version|grep "GNU assembler"|awk '{print $$3}'|awk -F .
> '{print $$2}')
> 
> to avoid errors for user not having «mips-linux-as» (I have
> mipsel-linux-as).
> 
> * should be used «allow_branch_to_undefined» or
> «mips_allow_branch_to_undefined» as GAS option? My toolchain use
> «allow_branch_to_undefined»...
> 
> * Variable MIPSFLAGS is ambiguous, I suggest using MIPSCFLAGS and/or
> MIPSLDFLAGS.
> 
> In the end I suggest the following patch for file cpu/mips/config.mk:
> 
> Index: cpu/mips/config.mk
> ===================================================================
> RCS file:
> /home/develop/cvs_private/uboot-mips-exadron/cpu/mips/config.mk,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 config.mk
> --- a/cpu/mips/config.mk        16 Sep 2005 12:14:19 -0000      1.1.1.1
> +++ b/cpu/mips/config.mk        16 Sep 2005 14:19:29 -0000
> @@ -21,20 +21,22 @@
>  # MA 02111-1307 USA
>  #
>  v=$(shell \
> -mips-linux-as --version|grep "GNU assembler"|awk '{print $$3}'|awk -F .
> '{print $$2}')
> -MIPSFLAGS=$(shell \
> +$(AS) --version|grep "GNU assembler"|awk '{print $$3}'|awk -F . '{print
> $$2}')
> +MIPSCFLAGS=$(shell \
>  if [ "$v" -lt "14" ]; then \
>         echo "-mcpu=4kc"; \
>  else \
> -       echo "-march=4kc -mtune=4kc
> -Wa,-mips_allow_branch_to_undefined"; \
> +       echo "-march=4kc -mtune=4kc -Wa,-allow_branch_to_undefined"; \
>  fi)
>  
>  ifneq (,$(findstring 4KCle,$(CROSS_COMPILE)))
> -ENDIANNESS = -EL
> -else
> -ENDIANNESS = -EB
> +MIPSCFLAGS += -EL
> +endif
> +ifneq (,$(findstring mipsel,$(CROSS_COMPILE)))
> +MIPSLDFLAGS += -EL
>  endif
>  
> -MIPSFLAGS += $(ENDIANNESS) -mabicalls
> +MIPSCFLAGS += -mabicalls
>  
> -PLATFORM_CPPFLAGS += $(MIPSFLAGS)
> +PLATFORM_CPPFLAGS += $(MIPSCFLAGS)
> +PLATFORM_LDFLAGS += $(MIPSLDFLAGS)
> 
> Ciao,
> 
> Rodolfo
> 
> -- 
> 
> GNU/Linux Solutions                  e-mail:    giometti at linux.it
> Linux Device Driver                             giometti at enneenne.com
> Embedded Systems                     home page: giometti.enneenne.com
> UNIX programming                     phone:     +39 349 2432127
> 
> 
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server.
> Download
> it for free - -and be entered to win a 42" plasma tv or your very own
> Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
</snip>

Your U-Boot support team