[DNX#2006033142000651] [U-Boot-Users] [PATCH] fix comment in net.c

DENX Support System support at denx.de
Fri Mar 31 23:50:26 CEST 2006


Hello list,

inside the automatic U-Boot patch tracking system a new ticket
[DNX#2006033142000651] was created:

<snip>
> Ron Alder wrote:
> > This patch fixes a comment in net/net.c
> > 
> > CHANGELOG:
> > * Fix comment in net/net.c
> >  Patch by Ron Alder, 09 Nov 2005
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > diff --git a/net/net.c b/net/net.c
> > --- a/net/net.c
> > +++ b/net/net.c
> > @@ -829,7 +829,6 @@ static ushort CDP_compute_csum(const uch
> >  		}
> >  		if (len) {
> >  			leftover = (signed short)(*(const signed char *)buff);
> > -			/* * XXX CISCO SUCKS big time! (and blows too) */
> >  			result = (result & 0xffff0000) | ((result + leftover) & 0x0000ffff);
> >  		}
> >  		while (result >> 16)
> 
> WTF is this? Politically correct day?
> 
> Since I wrote the comment in question let me elaborate.
> 
> CDP uses the ip checksum algorithm with a twist; for the last
> byte it *sign* extends and sums. Obviously this is is completely
> braindead, and warants the comment and much more :)
> 
> Regards
> 
> Pantelis
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server.
> Download
> it for free - -and be entered to win a 42" plasma tv or your very own
> Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
</snip>

Your U-Boot support team




More information about the U-Boot mailing list