[DNX#2006033142000294] [U-Boot-Users] [Patch] KVME080 Support
DENX Support System
support at denx.de
Fri Mar 31 23:50:12 CEST 2006
Hello list,
inside the automatic U-Boot patch tracking system a new ticket
[DNX#2006033142000294] was created:
<snip>
> Hi,
> >
> > Can you please split your patch into two?
> >
> I splited the patch and extracted KVME080 parts only.
>
> >
> > And please cleanup your code before re-submitting:
> >
> > * It violates the coding style requirements (trailing white space).
> >
> Sorry, I was suprised that my code had so many white spaces.
> I am sure I fixed all of it now.
>
> > * Using globally visible preprocessor defines like FLASH_WRITE64 is
> > not acceptable (you also forgot to document these, but that would
> > help either), and defining such code in the board config file is
> > the wrong way to implement it either. The board config file is -
> > ummm, a _configuration_ file, but does not contain source code.
> >
> I deleted the 'source code' from the board configuration file.
> The current version of KVME080 board runs well without patching
> cfi_flash.c
> I'll find an alternative way and send the patch for cfi_flash.c later.
>
> >
> > Also: please read the recent "U-Boot Developer's Information"
> > posting; you are supposed to provide a "sign-off" line for all
> > patches.
> >
> I added the "sign-off" line at the end of the patch.
>
> Regards,
> Sangmoon Kim
</snip>
Your U-Boot support team
More information about the U-Boot
mailing list