[U-Boot-Users] [PATCH] Add stricmp to lib_generic/string.c
Alan J. Luse
alanl at timeamerica.com
Wed May 3 00:41:52 CEST 2006
> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de]
> Sent: Tuesday, 02 May 2006 3:35 PM
> To: Alan J. Luse
> Cc: u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [PATCH] Add stricmp to
> lib_generic/string.c
>
> In message
> <5642B638DBEF6A4DBF9E9BC68144866D0276A59D at tamail1.timeamerica.
> com> you wrote:
> >
> > > Why should we add this? There is no code in U-Boot that
> uses such a
> > > function.
> >
> > An upcoming submission uses stricmp. I can wait and submit this
> > addition at that time if you like.
>
> Try to avoid stricmp(). I will tend to reject it because it adds code
> size for very little benefit.
>
> Best regards,
>
> Wolfgang Denk
>
Wolfgang-
I rechecked where I was using it and can easily eliminate the reference
making the patch submitted unnecessary.
Curiously enough I also ran a check to see where strnicmp is being used
in all of U-Boot, since I was considering using it instead, and it
doesn't seem to be used at all either even though its already in
string.c. I will avoid using it as well since its an obvious candidate
for elimination.
Regards,
Alan J. Luse
Embedded Systems Engineer
Time America, Inc.
More information about the U-Boot
mailing list