[U-Boot-Users] [PATCH 1/1] Supplemental USB patch to previous 14 patches.

[Wolfgang Denk]

In message <20060530225053.7575ab34 at localhost.localdomain> you wrote:
> 
> 1: For Adder ports, the Makefile shall be amended to optionally add
> CONFIG_USB_TTY to config.h as CONFIG_MPC852T is added by make AdderII_config.
> This will provisionally imply an appendation of USB to the config name. Hence
> three new values should be added to Makefile AdderUSB_config,
> Adder87xUSB_config and AdderIIUSB_config. - Do all these boards have USB
> facility ? 

Please hold on for a minute. The  Makefile's  purpose  is  to  define
dependencies.   It  is  actually  not  the  place  to  put  code  and
configuration trickery there. Yes, I know, this  is  already  in  use
with  other  boards, but I would like to ask you to use such features
only when absolutely necessary.

If you just define a new make target name this is simple and readable
(just a single word in the Makefile), and can  be  evaluated  in  the
board config file instead.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Behind every great man, there is a woman -- urging him on.
	-- Harry Mudd, "I, Mudd", stardate 4513.3