[U-Boot-Users] [PATCH 03/10 v3]: mpc7448hpc2 platform support header file

[Sam Song]

Hi,

The following feedback can be considered for next
fixes. Not to take effect on this patchset apply.

Zang Roy-r61911 <tie-fei.zang at freescale.com> wrote:
[snip]
> +#define CONFIG_TESTDRAMDATA     y
> +#define CONFIG_TESTDRAMADDRESS  n
> +#define CONFIG_TESETDRAMWALK    n

I don't know the meaning of this stuff.
Ummm, where are they applied?

> +/* Flash banks JFFS2 should use */
> +#define CFG_JFFS2_FIRST_BANK   1
> +#define CFG_JFFS2_NUM_BANKS    1

Without CFG_CMD_JFFS2 marco, what's the purpose
of this?

> +#define CONFIG_COMMANDS (CONFIG_CMD_DFL \
> +		| CFG_CMD_ASKENV \
> +		| CFG_CMD_CACHE \
> +		| CFG_CMD_PCI \
> +		| CFG_CMD_I2C \
> +		| CFG_CMD_SDRAM \
> +		| CFG_CMD_EEPROM \
> +		| CFG_CMD_NET \

CFG_CMD_NET has been included in DFL.

> +		| CFG_CMD_FLASH \

Also check this one, pls.

> +		| CFG_CMD_ENV \

And this one as well.

> +#define CFG_DRAM_TEST

Why enable DRAM test process during boot up?
Seems it's common to disable this option.

> + * DRAM tests
> + *   CFG_DRAM_TEST - enables the following tests.
> + *
> + *   CFG_DRAM_TEST_DATA - Enables test for shorted
> or open data lines
> + *			  Environment variable 'test_dram_data' must
> be
> + *			  set to 'y'.
> + *   CFG_DRAM_TEST_DATA - Enables test to verify

Two CFG_DRAM_TEST_DATAs have different meaning?

Thanks,

Sam



		
___________________________________________________________ 
雅虎免费邮箱-3.5G容量，20M附件 
http://cn.mail.yahoo.com/